OptionalInt model: deterministic of/empty/isPresent/isEmpty/getAsInt - #41
Open
tautschnig wants to merge 1 commit into
Open
OptionalInt model: deterministic of/empty/isPresent/isEmpty/getAsInt#41tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a minimal, executable JBMC model for java.util.OptionalInt to support deterministic construction and basic accessors consistent with the JDK contract.
Changes:
- Introduces
java.util.OptionalIntwithempty(),of(int),isPresent(),isEmpty(), andgetAsInt()(throwingNoSuchElementExceptionwhen absent). - Adds an
orElse(int)convenience method (not mentioned in the PR description).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+7
| package java.util; | ||
|
|
||
| /** | ||
| * JBMC model of java.util.OptionalInt. | ||
| * A simple value container: either empty or holds an int. | ||
| */ | ||
| public final class OptionalInt { |
Minimal executable model of java.util.OptionalInt: a (present, value) pair with deterministic of()/empty() constructors, isPresent()/isEmpty() accessors, getAsInt() throwing NoSuchElementException on the absent value per the JDK contract, and orElse(int). empty() deliberately allocates per call rather than caching a static singleton as the JDK internals do: OptionalInt's javadoc explicitly disclaims singleton-ness of empty() and forbids == comparison, so per-call allocation is contract-conformant -- and a static object field (the first in this model library) would become nondeterministic under JBMC's --nondet-static, making empty().isPresent() spuriously satisfiable. Carries the standard OpenJDK GPLv2+Classpath header, consistent with the sibling java.util model files. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
force-pushed
the
model-optionalint
branch
from
July 28, 2026 23:45
c564b63 to
5dd4167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal executable model of java.util.OptionalInt: a (present, value) pair with deterministic of()/empty() constructors, isPresent()/isEmpty() accessors, and getAsInt() throwing NoSuchElementException on the absent value, per the JDK contract.