PB-1420: Add Windows to CI testing matrix#234
Merged
Conversation
eirinikouvara
approved these changes
May 28, 2026
Contributor
eirinikouvara
left a comment
eirinikouvara
left a comment
There was a problem hiding this comment.
Looks good to me! Exciting to see this go in!
cjfuller-dev
force-pushed
the
PB-1420-chris-windows-ci-matrix
branch
from
45fbb3d to
859d2a8
Compare
Add windows-latest to the OS matrix for unit and functional tests. Set shell: bash as the default to ensure cross-platform compatibility. Remove CI/run_tests_unit.sh and CI/run_tests_functional.sh, inlining the pytest commands directly in the workflow. Update git_hooks/pre-push accordingly.
Remove the defaults.run.shell: bash override so that Windows runners use PowerShell (their default) rather than Git Bash. This better reflects how users actually run the SDK on Windows.
cjfuller-dev
force-pushed
the
PB-1420-chris-windows-ci-matrix
branch
from
859d2a8 to
4d9db76
Compare
cariad
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
windows-latestto the CI testing matrix for unit and functional tests, ensuring the SDK is validated on Windows.Changes
os: [ubuntu-latest, windows-latest]to the strategy matrixdefaults: run: shell: bashat the workflow level (Git Bash is available on Windows runners)sh CI/run_tests_unit.shandsh CI/run_tests_functional.shwith directpoetry run pytestcommands for cross-platform compatibilityWhat was tested