fix: include filename extension in imports#209
Merged
Conversation
gmaclennan
force-pushed
the
fix/import-filename-extensions
branch
from
July 23, 2026 12:19
2383eb5 to
3e02485
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local imports in
src/did not include the filename extension.js, and the inherited tsconfig fromexpo-module-scripts/tsconfig.baseuses"moduleResolution": "bundler"which is basically "the bundler will deal with it", and tsc just passes it through unmodified. Metro under strict ESM mode though refuses to add the.jsextension to imports that miss them (previous versions of Metro were more lenient).Two fixes:
"moduleResolution": "nodenext"intsconfig.jsonso that a missing extension is a compile error.