Add additional tests for maps functionality #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
* feat/map-sharing: pin ky@1.7.5 to fix node18 hang add tests from review Switch errors to .message not .error fix map shares test
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
It seems like there is a bug in the eventsource-client code that can mean a message can be missed before adding the async iterator. This fix uses the onMessage option to avoid missing messages.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This reverts commit 0002894.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new tests for error handling and resource management in the maps module, including scenarios for deleting and uploading maps, as well as structured error responses. Enhance error codes to improve clarity in responses.