story/HOP-68

[Girik1105]

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

• I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
• I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
• I do not have any sysout statements in my code or commented out code that isn’t needed anymore
• I am not reformatting any files in the wrong format or without cause.
• I am not changing file encoding or line endings to something else than UTF-8, LF
• My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
• I have added Javadoc/documentation where appropriate
• I have added test cases where appropriate
• I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

I needs to be possible to add a file in the KB that's not in Hopper to Hopper

Description

right now I can remove them from the KB but not add them to Hopper.
Context: after uploading a zip with many files, several files seemed to have timed out at some point and as a result not have been added to Hopper (I thought we addressed this before?). Now they show up as present in the KB but not in Hopper. I need to be able to add them to Hopper.

HOP-68

Anything else the reviewer needs to know?

Does this Pull request depend on any other?

[diging-jenkins]

Can one of the admins verify this patch?

[jdamerow]

what does that mean "propagate as today"?

[jdamerow]

Either this split should happen in line 381 (filename, content = download_kb_pdf(doc_id)) or there needs to be a comment that downloaded is actually a tuple. If I hadn't just reviewed the code for download_kb_pdf I would be very confused about this line (it's not super intuitive).