You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The with: block for the "Deploy Firebase Functions" step isn't marked as added and may be misaligned, resulting in invalid YAML. Ensure it has the correct + prefix and indentation under the uses key.
The conditional expressions for service_account_json and project_id use &&/||. Verify that these follow GitHub Actions expression rules and yield the correct secrets and project IDs in all environments.
Why: Adding a 'version' input may be helpful if the composite action requires it, and the improved_code correctly shows how to include it; however, the requirement is speculative without examining the action metadata.
Low
MaitreyaBuddha
changed the title
Kelly/use action for local deploy2
feat: Use action for local deploy
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Migrate Firebase deploy steps to shared action
Remove manual Node, Python, gcloud and CLI setup
Pass environment, service_account_json, project_id inputs
Add contents read permission for PR title linter
Changes walkthrough 📝
deploy-functions.yml
Migrate deploy-functions to reusable action.github/workflows/deploy-functions.yml
environment,service_account_json,project_idlint-pr-title.yml
Grant contents read for PR title lint.github/workflows/lint-pr-title.yml
contents: readpermission for workflows