Skip to content

Fix compact tc028#258

Merged
mielvds merged 3 commits into
masterfrom
fix-compact-tc028
May 11, 2026
Merged

Fix compact tc028#258
mielvds merged 3 commits into
masterfrom
fix-compact-tc028

Conversation

@mielvds
Copy link
Copy Markdown
Collaborator

@mielvds mielvds commented May 7, 2026

This PR fixes two related tests in the test-suite:

https://w3c.github.io/json-ld-api/tests/compact-manifest.html#tc028 (this also means 100% spec compliance on compaction)

Adding a minimal/empty property-scoped context should not affect the using terms defined in outer context.

https://w3c.github.io/json-ld-api/tests/toRdf-manifest.html#tc036

Adding a minimal/empty property-scoped context should not affect expansion of terms defined in the outer scope.

The issue probably originated from the Javascript port, where empty objects are truthy. Python treats an empty {} as falsey, so @context: {} was stored as False, which later means "reset/nullify the context." Now only explicit null becomes False; empty contexts are preserved.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

@mielvds mielvds force-pushed the fix-compact-tm023 branch from ff188e3 to 4377f59 Compare May 11, 2026 09:21
Base automatically changed from fix-compact-tm023 to master May 11, 2026 09:22
@mielvds mielvds force-pushed the fix-compact-tc028 branch from 2f4f18a to dfa8d4b Compare May 11, 2026 09:36
@mielvds mielvds merged commit 4f9dcb1 into master May 11, 2026
16 checks passed
@mielvds mielvds deleted the fix-compact-tc028 branch May 11, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants