Fix compact tc028#258
Merged
Merged
Conversation
anatoly-scherbakov
approved these changes
May 7, 2026
ff188e3 to
4377f59
Compare
2f4f18a to
dfa8d4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two related tests in the test-suite:
https://w3c.github.io/json-ld-api/tests/compact-manifest.html#tc028 (this also means 100% spec compliance on compaction)
https://w3c.github.io/json-ld-api/tests/toRdf-manifest.html#tc036
The issue probably originated from the Javascript port, where empty objects are truthy. Python treats an empty {} as falsey, so @context: {} was stored as False, which later means "reset/nullify the context." Now only explicit null becomes False; empty contexts are preserved.