Fix test manifest options and handle @json type gracefully#260
Merged
Conversation
anatoly-scherbakov
approved these changes
May 8, 2026
2f4f18a to
dfa8d4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the last outstanding tests for
flatten()andframe().In includes two fixes:
create_test_options(), instead of the other way around. In case ofextractAllScripts, the default isTrue, while most tests except one expectFalse. However, in the test manifestFalseis the default and therefore not explicitly provided. Hence, there was no way to provide this value through the test setup.@typeis@jsonin a frame, it no longer raises an "Invalid JSON-LD syntax" error.