add examples#10
Merged
Merged
Conversation
The VC Examples repo can be used locally for testing (if the `examplesBaseUrl` is changed in `app.js`: https://github.com/credential-handler/vc-examples
bparth24
approved these changes
Nov 25, 2025
bparth24
left a comment
bparth24
left a comment
Collaborator
There was a problem hiding this comment.
Quickly reviewed - LGTM. At some point later, I will run and test it locally.
Collaborator
Author
|
That's merged now. |
Deploying vc-viewer with
|
| Latest commit: |
5bf4a46
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a1a219c4.vc-viewer.pages.dev |
| Branch Preview URL: | https://add-examples.vc-viewer.pages.dev |
davidlehn
approved these changes
Jan 30, 2026
davidlehn
left a comment
davidlehn
left a comment
Member
There was a problem hiding this comment.
- Looking good!
- Some console errors like trying to load
did:exampleanddid:key, and some other things I didn't look into. Can be dealt with later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rendered.Wired up Cloudflare Pages for previews (only, for now). Checkout https://add-examples.vc-viewer.pages.dev/