route improvements#1
Open
EliasFernandes03 wants to merge 2 commits intodigitalcollege-classes:mainfrom
Open
Conversation
EliasFernandes03
commented
Mar 15, 2024
EliasFernandes03
commented
- A idéia era evitar a repetição de CursoController::class
- Evitar a repetição de '/cursos' nas rotas
- Mudei o método de add para adicionar, a fim de se encaixar na lógica.
alessandrofeitoza
requested changes
Mar 15, 2024
Comment on lines
+11
to
+16
| $cursoRoutes = [ | ||
| 'listar', | ||
| 'adicionar', | ||
| 'editar', | ||
| 'excluir' | ||
| ]; |
Contributor
There was a problem hiding this comment.
boa, gostei da abordagem, mas isso de certa forma nos restringe a precisar ter na url o mesmo nome do metodo, o que pode se tornar um problema de segurança.
Mas a ideia é essa, fazer sub arrays
Ah, vamos precisar mudar a logica tbm lá no index.php
Author
There was a problem hiding this comment.
Vou tentar mais um pouco da forma que eu tava pensando, fazer um array onde seria /cursos e dentro dele as outras rotas.
|
Olha agora que vi, usei exatamente essa logica, so que fiz um foreach na logica do index. e podemos usar o mesmo modelo por exeplo para AlunosController.php.. etc... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.