Support OpenID4VP multi-signed request in Rust matcher#45
Open
QZHelen wants to merge 1 commit into
Open
Conversation
netheril96
requested changes
Jul 8, 2026
| pub dcql_query: Option<DcqlQuery>, | ||
| pub offer: Option<JsonValue>, | ||
| pub transaction_data: Vec<String>, | ||
| pub request: String, |
Collaborator
There was a problem hiding this comment.
I'd like to avoid using JsonValue as much as possible. It removes the clarity and guardrails provided by static typing.
We should make request an enum of either a string or a struct with the right fields, and implement a custom DeJson for it, just like how ProtocolRequestData is done.
In addition, the payload field seems to be a mistake. Judging from the test data, it is a subfield of request instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.