fix: critical server-side bugs in spigot module#4
Open
thehaffk wants to merge 1 commit into
Open
Conversation
- Fix permission bypass: DeleteCommand now checks display ownership before allowing deletion (non-owners need admin permission) - Fix data corruption: unpackX sign extension for negative X coordinates that caused displays to appear at wrong positions after DB reload - Fix null world crash: skip displays from unloaded worlds during DB load instead of propagating null Location through the system - Fix race conditions: replace HashMap with ConcurrentHashMap in StateManager, PlayerManager (5 maps), and SelectionManager - Add max_displays_per_player config (default 10) to prevent unbounded display creation that degrades server performance - Fix blocking I/O: replace Bukkit.getOfflinePlayer() with getPlayer() in ListCommand and InfoCommand to avoid disk reads on main thread
thehaffk
force-pushed
the
fix/server-side-bugfixes
branch
from
March 1, 2026 16:27
e613c4f to
519892e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan