Skip to content

do-agent: add SI metrics support with aggregation and whitelist #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamshadmirza wants to merge 3 commits into
base: master
Choose a base branch
from
Open

do-agent: add SI metrics support with aggregation and whitelist #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b20025
do-agent: add SI metrics support with aggregation and whitelist
iamshadmirza Mar 11, 2026
8b78bd2
formatting fixes
iamshadmirza Mar 13, 2026
026fe37
update metric list
iamshadmirza Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions cmd/do-agent/aggregation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,3 +237,25 @@ var diAggregationSpec = map[string][]string{
"gradient_infra_di_vllm:request_time_per_output_token_seconds_bucket": diLabelsToDrop,
"gradient_infra_di_vllm:time_to_first_token_seconds_bucket": diLabelsToDrop,
}

// SI metrics: drop high-cardinality labels we don't want to keep.
var siLabelsToDrop = []string{
"container",
"job",
"otel_scope_name",
"otel_scope_schema_url",
"otel_scope_version",
"resource_uuid",
}

var siAggregationSpec = map[string][]string{
"gen_ai_platform_inference_proxy_http_requests_total": siLabelsToDrop,
"gen_ai_platform_inference_proxy_http_request_duration_seconds": siLabelsToDrop,
"gen_ai_platform_inference_proxy_token_throughput": siLabelsToDrop,
"gen_ai_platform_inference_proxy_rate_limit_exceeded": siLabelsToDrop,
"gen_ai_platform_inference_proxy_cache_hit": siLabelsToDrop,
"gen_ai_platform_inference_proxy_cache_miss": siLabelsToDrop,
"gen_ai_platform_inference_proxy_inference_client_ttft_duration": siLabelsToDrop,
"gen_ai_platform_inference_proxy_inference_client_itl_duration_seconds": siLabelsToDrop,
"gen_ai_platform_inference_proxy_inference_client_requests_total": siLabelsToDrop,
}
18 changes: 18 additions & 0 deletions cmd/do-agent/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ var (
defaultMaxMetricLength int
promAddr string
diMetricsPath string
siMetricsPath string
gpuMetricsPath string
topK int
scrapeTimeout time.Duration
Expand Down Expand Up @@ -131,6 +132,9 @@ func init() {
kingpin.Flag("di-metrics-path", "enable Dedicated Inference (DI) metrics collection from a prometheus endpoint").
StringVar(&config.diMetricsPath)

kingpin.Flag("si-metrics-path", "enable Serverless Inference (SI) metrics collection from a prometheus endpoint").
StringVar(&config.siMetricsPath)

kingpin.Flag("web.listen", "enable a local endpoint for scrapeable prometheus metrics as well").
Default("false").
BoolVar(&config.webListen)
Expand Down Expand Up @@ -267,6 +271,11 @@ func initAggregatorSpecs() map[string][]string {
aggregateSpecs[k] = append(aggregateSpecs[k], v...)
}
}
if config.siMetricsPath != "" {
for k, v := range siAggregationSpec {
aggregateSpecs[k] = append(aggregateSpecs[k], v...)
}
}
return aggregateSpecs
}

Expand Down Expand Up @@ -350,6 +359,15 @@ func initCollectors() []prometheus.Collector {
}
}

if config.siMetricsPath != "" {
si, err := collector.NewScraper("si", config.siMetricsPath, nil, siWhitelist, collector.WithTimeout(config.scrapeTimeout))
if err != nil {
log.Error("Failed to initialize SI metrics collector: %+v", err)
} else {
cols = append(cols, si)
}
}

if config.gpuMetricsPath != "" {
gpu, err := collector.NewScraper("gpu", config.gpuMetricsPath, nil, gpuWhitelist, collector.WithTimeout(config.scrapeTimeout))
if err != nil {
Expand Down
12 changes: 12 additions & 0 deletions cmd/do-agent/whitelist.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,3 +274,15 @@ var diWhitelist = map[string]bool{
"gradient_infra_di_vllm:request_time_per_output_token_seconds_bucket": true,
"gradient_infra_di_vllm:time_to_first_token_seconds_bucket": true,
}

var siWhitelist = map[string]bool{
"gen_ai_platform_inference_proxy_http_requests_total": true,
"gen_ai_platform_inference_proxy_http_request_duration_seconds": true,
"gen_ai_platform_inference_proxy_token_throughput": true,
"gen_ai_platform_inference_proxy_rate_limit_exceeded": true,
"gen_ai_platform_inference_proxy_cache_hit": true,
"gen_ai_platform_inference_proxy_cache_miss": true,
"gen_ai_platform_inference_proxy_inference_client_ttft_duration": true,
"gen_ai_platform_inference_proxy_inference_client_itl_duration_seconds": true,
"gen_ai_platform_inference_proxy_inference_client_requests_total": true,
}
Loading