Skip to content

fixed broken shell function#27

Open
jjaimealeman wants to merge 8 commits intodevelopfrom
master
Open

fixed broken shell function#27
jjaimealeman wants to merge 8 commits intodevelopfrom
master

Conversation

@jjaimealeman
Copy link
Copy Markdown

//cleans our dist directory in case things got deleted
//gulp.task('clean', function() {
// return shell.task([
// 'rm -rf dist'
// ]);
// });
gulp.task('clean', shell.task([
'rm -rf dist'
]));

//create folders using shell
// gulp.task('scaffold', function() {
// return shell.task([
// 'mkdir dist',
// 'mkdir dist/fonts',
// 'mkdir dist/images',
// 'mkdir dist/scripts',
// 'mkdir dist/styles'
// ]
// );
// });
gulp.task('scaffold', shell.task([
'mkdir dist',
'mkdir dist/fonts',
'mkdir dist/images',
'mkdir dist/scripts',
'mkdir dist/styles'
]));

ryanbenson and others added 6 commits December 15, 2015 11:28
That should only belong in the final build
I just made minor change, updating gulp components version. This helped me and runs tasks faster.
Updated components version
@ryanbenson
Copy link
Copy Markdown
Contributor

Thanks for sending this over :D I'll check it out today. It seems like a quick fix. I appreciate the help!

@ryanbenson
Copy link
Copy Markdown
Contributor

Thanks again for updating this for everyone :) This is probably my fault, but I can't merge in the develop branch for this repo, because I was using the develop branch to completely re-write this project. I'm not sure if that was the best place to put it, but Harvest 2.0 is going to be a pretty big shift from Harvest 1.0.

I could just replicate your changes myself, but I want to give you credit for the fix! Would you mind creating a new & fresh branch and putting your changes on there, then I can merge it in?

Also, you don't need to comment out the updated code, you can just replace it instead of keeping the outdated shell work in there :)

Thanks again,

Ryan

@jjaimealeman
Copy link
Copy Markdown
Author

jjaimealeman commented Sep 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants