Fix keyboard conflicts, async error handling, and profile validation#6
Draft
Fix keyboard conflicts, async error handling, and profile validation#6
Conversation
Co-authored-by: diluteoxygen <82773456+diluteoxygen@users.noreply.github.com>
…Settled Co-authored-by: diluteoxygen <82773456+diluteoxygen@users.noreply.github.com>
Co-authored-by: diluteoxygen <82773456+diluteoxygen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix keyboard shortcut conflict and enhance toggle logic
Fix keyboard conflicts, async error handling, and profile validation
Feb 14, 2026
diluteoxygen
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses keyboard shortcut conflicts with browser defaults, race conditions in async extension toggle logic, inadequate profile name validation allowing reserved prefixes in imports, and CSS rule conflicts.
Keyboard Shortcuts
vm.switch.flip()(UI observables) andperformToggle()(background service worker)Async Error Handling (migration.js)
Fixed ineffective try/catch on promise-returning
chrome.management.setEnabled():Added error handlers to all
chrome.storage.sync.setcalls.Profile Validation
validateProfileName(): rejects "__" prefix, enforces 30-char limit, trims whitespaceexportProfiles: filters out reserved profiles (!name.startsWith('__'))importProfiles: validates before adding, skips invalid namesself.add(): acceptsinternalflag to allow reserved names only from internal calls (e.g.,selectReserved)CSS Consolidation
Resolved conflicting display/visibility rules:
#import-result.visible,#import-error.visible) withdisplay: block.visible,.hidden,.fadeoutwithvisibilityfor animationsDocumentation
Updated
Update.mdpriority status to reflect completed Manifest V3 migration, CSP, and error handling (0/3 → 3/3).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.