Conversation
deontologician
force-pushed
the
bevy-main-fixes
branch
from
d12b45c to
8111354
Compare
The biggest change here is that doing the same query twice, one mutably and one immutably, is no longer needed, once bevyengine/bevy#2305 lands. Before that lands, however, this upgrade is actually impossible to do safely, since the `q0`/`q0_mut` distinction is gone and therefore it's impossible to implement the Rapier component traits on Bevy queries. (This is filed upstream as bevyengine/bevy#2744.) Therefore, this upgrade has to wait until that Bevy PR lands. Other minor changes: * `Light` has been renamed to `PointLight`. * `App::build()` is now `App::new()`, and `AppBuilder` is now `App`. * `glam` has been upgraded upstream.
|
This is now updated with all fixes I know of to get It depends on the changes in these two PRs: plus bevy from this PR: This is obviously a bit of a mess, so I don't expect it to be merged as-is, but this is working code that with elbow grease gets |
|
As a heads up: I'm planning on merging bevyengine/bevy#2305 tomorrow, which should hopefully unblock the work being done here |
|
bevyengine/bevy#2305 is merged! |
|
Bevy 0.6 was just released. Can we get this ball rolling again? |
|
@cart Perfect! Congrats for the release 🎊 I will take a look at this tomorrow. |
|
Thank you for this PR @deontologician! I will go for the solution based on wrapper types #102. It is less intrusive and sounds more future-proof to me since I will experiment with making more idiomatic components directly into |
|
A good call, I tried to get a wrapper solution working but it seemed to be an endless rabbit hole. Glad someone made a working PR for that |
4 participants
Some fixes I had to make to get bevy_rapier to compile against the latest bevy
main.AppBuilderhas been folded intoAppApp::world()is now just a public field, not a methodglam0.15 instead of 0.13from_slice_unaligned