feat: add GeometricMean coefficient combine rule#914
Open
HueCodes wants to merge 1 commit intodimforge:masterfrom
Open
feat: add GeometricMean coefficient combine rule#914HueCodes wants to merge 1 commit intodimforge:masterfrom
HueCodes wants to merge 1 commit intodimforge:masterfrom
Conversation
Add CoefficientCombineRule::GeometricMean which computes sqrt(coeff1 * coeff2). This provides a more physically realistic way to combine friction/restitution coefficients, commonly used in physics engines like Box2D. Uses .abs() before sqrt to handle negative coefficients defensively, consistent with the Min rule's handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #685
Fresh implementation since #826 has merge conflicts.
Adds
CoefficientCombineRule::GeometricMeanwhich computessqrt(coeff1 * coeff2).This provides a more physically realistic way to combine friction/restitution coefficients:
Uses
.abs()before sqrt to handle negative coefficients defensively (consistent with Min rule).Includes unit tests for basic usage, edge cases (zero, negative, same values), priority, and ordering.