Skip to content

Auto-fix CI failures for PR #1175 #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

Auto-fix CI failures for PR #1175 #1181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/langfuse/trace-proxy-request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ export async function traceProxyRequest(ctx: TraceContext): Promise<void> {
);

// Explicitly set trace-level input/output (propagateAttributes does not support these)
rootSpan.updateTrace({
rootSpan.setTraceIO({

@chatgpt-codex-connector chatgpt-codex-connector Bot May 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the Langfuse test mock for setTraceIO

In the unit-test environment, mockRootSpan in tests/unit/langfuse/langfuse-trace.test.ts still only defines updateTrace and the assertions still expect that method. After this call switches to setTraceIO, every successful trace path hits TypeError: rootSpan.setTraceIO is not a function, which is swallowed by the catch block before rootSpan.end() runs, so the Langfuse trace tests now fail instead of validating trace IO. Please update the test mock and expectations alongside this SDK method rename.

Useful? React with 👍 / 👎.

input: actualRequestBody,
output: actualResponseBody,
});
Comment on lines +411 to 414

@greptile-apps greptile-apps Bot May 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 setTraceIO is deprecated in the v5 SDK

The Langfuse JS/TS v5 migration guide marks setTraceIO() as deprecated — it exists only for backward compatibility with legacy trace-level LLM-as-a-judge evaluators. The project already declares @langfuse/tracing@^5. The recommended v5 approach is to set input/output directly on the root observation instead of calling setTraceIO on the span. While this fix unblocks the TypeScript build, it lands on a deprecated code path that may be removed in a future SDK minor or major.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/lib/langfuse/trace-proxy-request.ts
Line: 411-414

Comment:
**`setTraceIO` is deprecated in the v5 SDK**

The Langfuse JS/TS v5 migration guide marks `setTraceIO()` as deprecated — it exists only for backward compatibility with legacy trace-level LLM-as-a-judge evaluators. The project already declares `@langfuse/tracing@^5`. The recommended v5 approach is to set `input`/`output` directly on the root observation instead of calling `setTraceIO` on the span. While this fix unblocks the TypeScript build, it lands on a deprecated code path that may be removed in a future SDK minor or major.

How can I resolve this? If you propose a fix, please make it concise.

Expand Down