Skip to content

fix(k8s): 修正 fetch 超时配置单位 #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qhongchen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(k8s): 修正 fetch 超时配置单位 #1284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions deploy/k8s/app/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,13 @@ spec:
value: "20"
- name: DB_POOL_CONNECT_TIMEOUT
value: "10"
# Fetch 超时单位为毫秒,需与 .env.example 和 env.schema.ts 保持一致。
- name: FETCH_CONNECT_TIMEOUT
value: "30"
#- name: FETCH_HEADERS_TIMEOUT
# value: "600"
#- name: FETCH_BODY_TIMEOUT
# value: "600"
value: "30000"
- name: FETCH_HEADERS_TIMEOUT
value: "600000"
- name: FETCH_BODY_TIMEOUT
value: "600000"
Comment on lines +60 to +66

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

问题分析

  1. 配置冗余与漂移风险：这些环境变量的值（30000、600000、600000）与 src/lib/config/env.schema.ts 中定义的默认值完全一致。在 Kubernetes 部署中显式设置这些默认值会导致配置冗余。如果未来在代码中调整了默认超时时间，而忘记同步更新 Kubernetes 清单，就会导致配置漂移。
  2. 注释描述不准确：注释中提到“需与 .env.example 保持一致”，但实际上 deploy/.env.example 文件中并没有包含这些 FETCH_* 相关的环境变量。

改进建议

建议将这些配置项注释掉，仅作为自定义参考保留。这样既能利用代码中的默认值，避免配置漂移，又能在需要自定义超时时间时方便运维人员修改。同时修正注释中关于 .env.example 的不准确描述。

            # Fetch 超时配置（单位为毫秒）。默认值已在 env.schema.ts 中定义，此处注释以供参考或自定义。
            # - name: FETCH_CONNECT_TIMEOUT
            #   value: "30000"
            # - name: FETCH_HEADERS_TIMEOUT
            #   value: "600000"
            # - name: FETCH_BODY_TIMEOUT
            #   value: "600000"

- name: ENABLE_RATE_LIMIT
value: "true"
- name: ENABLE_API_KEY_REDIS_CACHE
Expand Down
Loading