Add custom HTTP headers support to authentication flows#145
Open
rikvanduijn wants to merge 2 commits intodirkjanm:masterfrom
Open
Add custom HTTP headers support to authentication flows#145rikvanduijn wants to merge 2 commits intodirkjanm:masterfrom
rikvanduijn wants to merge 2 commits intodirkjanm:masterfrom
Conversation
dirkjanm
requested changes
Feb 5, 2026
Owner
dirkjanm
left a comment
There was a problem hiding this comment.
seems some artifacts of the merge are still in the code, if you can clean that up I can merge the PR. great addition!
roadlib/roadtools/roadlib/auth.py
Outdated
| """ | ||
| self.user_agent = self.lookup_user_agent(useragent) | ||
|
|
||
| <<<<<<< Updated upstream |
roadlib/roadtools/roadlib/auth.py
Outdated
| """ | ||
| if headers_dict: | ||
| self.custom_headers = headers_dict | ||
| >>>>>>> Stashed changes |
Contributor
Author
There was a problem hiding this comment.
Ah yes my changes were done so long a go. Was running way behind on your version. Will make sure to fix em!
Contributor
Author
|
Ive removed the artifacts |
|
Did you do it or your assistant ? ;) |
Contributor
Author
|
I'm saving this thread. Good job to the both of you. Never thought I'd live to see the day that memes ended up in PR reviews but this made me laugh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
This PR adds support for custom HTTP headers in ROADtools authentication flows. Users can now specify custom headers that will be included in all HTTP requests made during authentication and API operations.
Changes
roadlib (roadtools/roadlib/auth.py):
roadtx (roadtools/roadtx/main.py):
Use Case
This feature enables users to pass custom HTTP headers like X-AnchorMailbox used by for example PIM authentication flow.
Usage Example
roadtx gettokens --headers '{"X-AnchorMailbox": "Oid:objectid@tenantid"}'