Conversation
Add configurable timeout and retry mechanisms to thulp-skills: - TimeoutConfig: skill/step/tool level timeouts with configurable actions - RetryConfig: max retries, backoff strategies (fixed/exponential/jitter) - RetryableError: categorize retryable errors (network, rate limit, timeout) - execute_with_config(): new method with full timeout/retry control - Per-step timeout and retry overrides via SkillStep fields This enables reliable skill execution for thulpoff evaluation runs and ehb conversation handling.
Add comprehensive session management to thulp-workspace including: - Session types with metadata, entries, and context storage - SessionManager for async file-based persistence - Turn counting with configurable limits (max turns, entries, duration) - Session filtering by status, type, tags, and timestamps - Entry types for user/assistant messages, tool calls, skill executions - In-memory caching with disk persistence This provides the foundation for tracking conversation history, evaluation runs, and skill execution sessions across thulp tools.
Add thulp-skill-files crate for parsing Claude-style skill files:
- SkillFile parser for YAML frontmatter and markdown content
- SkillPreprocessor for $ARGUMENTS, {{variable}}, ${ENV}, and command substitution
- SkillLoader for discovering skills from multiple directories
- Scope-based priority resolution (Enterprise > Personal > Project)
- Tool restriction support via allowed-tools frontmatter
- Marketplace extensions (version, author, price, tags)
This enables thulp to load and execute skills defined in SKILL.md files
compatible with the Claude Code/OpenCode skill format.
- Add SkillExecutor trait abstracting skill execution logic - Add ExecutionContext for managing inputs, outputs, and config between steps - Add StepResult type for individual step outcomes with timing/retry info - Add ExecutionHooks trait for lifecycle callbacks (before/after skill/step) - Add DefaultSkillExecutor implementation using Transport trait - Add NoOpHooks, TracingHooks, and CompositeHooks implementations - Improve variable substitution to handle JSON object placeholders - Add Default derive for SkillStep This enables custom execution strategies and better observability through the hooks system while maintaining backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds several major features to thulp-skills and thulp-workspace crates:
Skills Execution Abstraction
SkillExecutortrait for pluggable execution strategiesExecutionContextfor managing inputs/outputs/config between stepsStepResulttype for individual step outcomes with timing and retry infoDefaultSkillExecutor<T, H>implementation using Transport traitLifecycle Hooks
ExecutionHookstrait for observing execution lifecycleNoOpHooks,TracingHooks, andCompositeHooksimplementationsSession Management (thulp-workspace)
Sessiontype with turn counting and limitsSessionManagerfor async file-based persistenceSkill File Parsing (thulp-skill-files)
Other Improvements
Defaultderive forSkillStepTesting
-D warnings