Skip to content

Add grpc-status-details-bin carrier shapes and grpcStatus, grpcErrorMessage traits#271

Merged
Baccata merged 4 commits intodisneystreaming:mainfrom
denisrosca:grpc_traits_new
Mar 18, 2026
Merged

Add grpc-status-details-bin carrier shapes and grpcStatus, grpcErrorMessage traits#271
Baccata merged 4 commits intodisneystreaming:mainfrom
denisrosca:grpc_traits_new

Conversation

@denisrosca
Copy link
Copy Markdown
Contributor

  • Add alloy.proto#ProtobufAny and alloy.proto#GoogleRpcStatus Smithy shapes wire-compatible with google.protobuf.Any and google.rpc.Status (field numbers via @alloy.proto#protoIndex) without importing google protos.
  • Add alloy.proto#grpcStatus trait (integer-valued) for error structures, plus GrpcStatusCode reference enum; implement Java trait provider and a warning-only validator for non-standard codes.
  • Add alloy.proto#grpcErrorMessage trait to mark error fields that should be used when returning errors
  • Update protobuf docs to cover grpc status details usage, typeUrl guidance (including # -> .), and behavior for status codes outside 0..16; add tests and register services/validators.

- Add alloy.proto#ProtobufAny and alloy.proto#GoogleRpcStatus Smithy shapes wire-compatible with google.protobuf.Any and google.rpc.Status (field numbers via @alloy.proto#protoIndex) without importing google protos.
- Add alloy.proto#grpcStatus trait (integer-valued) for error structures, plus GrpcStatusCode reference enum; implement Java trait provider and a warning-only validator for non-standard codes.
- Add alloy.proto#grpcErrorMessage trait to mark error fields that should be used when returning errors
- Update protobuf docs to cover grpc status details usage, typeUrl guidance (including # -> .), and behavior for status codes outside 0..16; add tests and register services/validators.
@denisrosca denisrosca marked this pull request as ready for review February 27, 2026 14:28
Comment thread modules/core/src/alloy/proto/validation/GrpcErrorMessageTraitValidator.java Outdated
@kubukoz
Copy link
Copy Markdown
Member

kubukoz commented Mar 3, 2026

formatting failed 😅

@Baccata Baccata merged commit 6656f04 into disneystreaming:main Mar 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants