Draft
Conversation
5035107 to
5148a5c
Compare
- Remove filler words and internal implementation details - Clarify `nested` with examples and defaults - Add JSDoc for HiddenSchema, ComputedSchema, DataSchema - Simplify DitoComponentInstance docs - Remove redundant type restatements
Contributor
|
@puckey thanks for these! It looks like there's a merge conflicts though? Could you take a look? Otherwise good to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve TypeScript type definitions across all three packages, developed step by step together with Claude.
Admin
SchemaFields,SchemaRoute,SchemaEvents,SchemaOpen,SchemaTextMixin,SchemaAffixMixin,SchemaDataMixin,WatchHandlers,PanelSchema,ClipboardConfig,DitoComponentInstanceclass,info,maxLength,prefix/suffix,search,editableon options)SchemaOptionsarray,parseaccessor,resizableas accessor)SchemaSetupMixin/SchemaRouteMixinwithSchemaFields/SchemaRoute(keeping deprecated aliases)CollectionControllerbase class,RelationControllerViewSchema,Form,Tabs)DitoContextproperties and utility types (Buttons,Resource,Components)Server
Model,Controller,Application, and action typesApplication(router, assets, validators, storage, services)Model(lifecycle hooks,$transaction,$emit,$filterGraph,$populateGraph,$formatDatabaseJson,$parseDatabaseJson)CollectionControllerbase class with query building and member resolutionCompiledParametersValidatortypemodify/filtertoModelRelationModelScopesignature,countreturn type (Promise<number>),ModelControllerHookskey typesAuthorizedocumentation andUsersController.isAuthenticatedUtils
isPlainObject,isObject,isInteger,isAsync, etc.)isArray,isPlainArray,isModule,defaultFormats)mergeDeeply,assignDeeply,mapConcurrently,mapSequentially, data path functions,toPromiseCallbackformat/formatDatevalue types, fixparseDataPathreturn type