Skip to content

fix(ci): make the UBSan gate abort on error (-fno-sanitize-recover=undefined) #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
div0rce merged 1 commit into from
Jun 25, 2026
Merged

fix(ci): make the UBSan gate abort on error (-fno-sanitize-recover=undefined) #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cmake/Sanitizers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,14 @@ if(QSL_ENABLE_ASAN AND QSL_ENABLE_TSAN)
endif()

if(QSL_ENABLE_ASAN)
add_compile_options(-fsanitize=address,undefined -fno-omit-frame-pointer)
# -fno-sanitize-recover=undefined makes UBSan ABORT on the first violation instead of its default
# "recover" mode (print a diagnostic and continue, with the process still exiting 0). Without it
# the UBSan half of this gate is non-functional: a pure-UBSan defect (signed overflow, invalid
# enum/bool load, out-of-range shift, misaligned/null pointer arithmetic) prints a warning but the
# test still PASSES, so `make asan` and the CI sanitizers job stay green. ASan already aborts on
# memory errors by default; this brings UBSan to parity.
add_compile_options(-fsanitize=address,undefined -fno-sanitize-recover=undefined
-fno-omit-frame-pointer)
add_link_options(-fsanitize=address,undefined)
endif()

Expand Down
Loading