Fix macOS tests and enable them in CI #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should eliminate flakiness if Driver takes longer than expected to start.
For mysterious reasons mDNS / bonjour does not work. Tried several workarounds, but it's just too annoying to debug.
yfyf
force-pushed
the
macos-tests-and-ci
branch
from
78bf2f8 to
a1ed855
Compare
knuton
approved these changes
Feb 5, 2026
Contributor
|
tests pass on mac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could reproduce the flaky test @stoeffel reported in #166 in Github Actions too. a03a0ab seems to get rid of it, but would be good to confirm. @stoeffel can you re-run
make testmultiple times on this branch?Also had to disable the Disocver test in CI for macOS runners (a1ed855), since there's no way to debug this and we anyway have it tested for Linux, which is what matters.