fix: scorecard workflow#896
Closed
niltonpimentel02 wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the OpenSSF Scorecard GitHub Actions workflow by removing an invalid key in the environment section that was causing workflow parsing/verification to fail (per issue #895).
Changes:
- Removed
deployment: falsefrom the jobenvironmentblock to comply with GitHub Actions workflow schema. - Restores Scorecard workflow validity so results can be sent to the Scorecard webapp without a 400 parse error.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
This is actually a problem with the ossf/scorecard-webapp. The deployment key is a new way to tell github to not generate a deployment for every action that uses and environment. We use environments to protect secrets with special access rules to harden the CI. I'm just letting scorecard be broken until the update their dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unexpected key from the workflow.
Closes #895