Skip to content

Stable/2.6.x#8

Open
djangodeveloper96 wants to merge 26 commits into
mainfrom
stable/2.6.x
Open

Stable/2.6.x#8
djangodeveloper96 wants to merge 26 commits into
mainfrom
stable/2.6.x

Conversation

@djangodeveloper96
Copy link
Copy Markdown
Owner

Thanks for contributing to Wagtail! 🎉

Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:

  • Do the tests still pass? (https://docs.wagtail.io/en/latest/contributing/developing.html#testing)
  • Does the code comply with the style guide? (Run make lint from the Wagtail root)
  • For Python changes: Have you added tests to cover the new/fixed behaviour?
  • For front-end changes: Did you test on all of Wagtail’s supported environments?
    • Please list the exact browser and operating system versions you tested.
    • Please list which assistive technologies you tested.
  • For new features: Has the documentation been updated accordingly?

gasman and others added 26 commits July 9, 2019 14:39
Only two Ss in accessor. Also make quotes consistent.
…978 (#5469)

User interaction with the form within the 10s delay also won’t trigger the confirmation message. There will still be race condition issues if form widgets like rich text take 10+ seconds to initialise – but that doesn’t seem likely.
It's not possible to use wagtail in a project with pylint and the
pylint-django plugin.

Pylint-django does not work with foreign keys that are referenced by
their string names. See: https://github.com/PyCQA/pylint-django#known-issues

If we simply replace the string name with the foreign-key class, linting
on wagtail projects is fixed.

Also see:
pylint-dev/pylint#2995
pylint-dev/pylint-django#241

Conflicts:
	CONTRIBUTORS.rst
Fixes #5547
As of Django 2.2.1, Value expressions within a SearchVector must specify an output_field: https://code.djangoproject.com/ticket/30446
Fixes #5585 and (at least partly) #5628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants