Update edition to 2021 & specify optional dependency pathway unambiguously#35
Open
Update edition to 2021 & specify optional dependency pathway unambiguously#35
Conversation
xacrimon
force-pushed
the
joel/rollup-misc
branch
from
c3a1404 to
08a0fd3
Compare
xacrimon
changed the title
xacrimon
changed the title
xacrimon
force-pushed
the
joel/rollup-misc
branch
from
08a0fd3 to
620059d
Compare
Contributor
Author
|
Yeah will do in a moment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couple of small "maintenance" things:
dep:cratesyntax to specify the dependency onserdeby theserde_implfeaturepubvisibilities#[inline]attributes onserializeandvisit_seqin the ser/de implementations. These can already be inlined even without LTO cross-crate because they are generic. There is also little reason to explicitly hint these to encourage additional inlining without a reason grounded in data due to their nature.