Wannabe Edgerunner Add-on - initial changes for review#8
Wannabe Edgerunner Add-on - initial changes for review#8DigitalVixenSWE wants to merge 1 commit intodjkovrik:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| // Wannabe Edgerunner Add-on - neuroblocker quality tracker (;¬_¬) | ||
| // watches for neuroblocker status effects applying/removing so we know which tier is active | ||
|
|
||
| module Edgerunning.System |
There was a problem hiding this comment.
I think it would be more convenient to use a unique module name for WEA so we can conditionally wrap some stuff inside EdgerunningSystem
| private persistent let humanityRestoringActionTakenShower: Bool = false; | ||
|
|
||
| // WEA Add-on fields (˘ω˘) | ||
| public let m_weaSleepPending: Bool; |
There was a problem hiding this comment.
Other fields are not using Hungarian notation so maybe rename this to similar naming for everything
|
|
||
| this.ScheduleHumanityRestoreEffect(psychoDuration + 3.0); | ||
|
|
||
| // WEA: hostility pulse - broadcast combat stims so nearby NPCs react to psychosis (╯°□°)╯︵ ┻━┻ |
There was a problem hiding this comment.
If WEA get its own module name then we can do something like this (just throwing some ideas off top of my head):
- Move all WEA new logic to a separate functions
- Add conditions for those funcs like this:
@if(ModuleExists("WeaModuleName"))
private func SomeFuncWithNewLogic() -> Void {
// this one has an actual logic needed for WEA
}
@if(!ModuleExists("WeaModuleName"))
private func SomeFuncWithNewLogic() -> Void {
// this one has empty body with no logic
}- Replace all new logic chunks inside EdgerunningSystem with conditional funcs calls
| } | ||
|
|
||
| public func OnRestoreAction(action: HumanityRestoringAction) -> Void { | ||
| // WEA: sleep verification - must actually sleep, not just tap the bed (¬_¬) |
There was a problem hiding this comment.
Same, needs wrapper func for conditional compilation (and a few other places inside EdgerunningSystem)
| } | ||
|
|
||
| // WEA Add-on helpers ٩(｡•́‿•̀｡)۶ | ||
| public func WEA_GetSmokeCount() -> Int32 { return this.m_weaSmokeCount; } |
There was a problem hiding this comment.
I think we can just merge all helpers as is with no conditions, just won't be used if no WEA installed
|
Things to check after all changes:
|
2 participants
First PR for the new wannabe add-on. For DJK review.