chore: add Ruff configuration and apply formating and linting changes#127
Open
galenseilis wants to merge 2 commits intodjordon:masterfrom
Open
chore: add Ruff configuration and apply formating and linting changes#127galenseilis wants to merge 2 commits intodjordon:masterfrom
galenseilis wants to merge 2 commits intodjordon:masterfrom
Conversation
Contributor
Author
|
This should solve #119 by using |
Contributor
Author
|
Hmm, actually, I am unsure if these changes will be compatible with all the versions of Python being supported. |
djordon
reviewed
Apr 24, 2025
Owner
djordon
left a comment
djordon
left a comment
There was a problem hiding this comment.
Largely looks good. I just have one question about the latex related changes in some of the docstring changes.
| def add_loss(self, qedge, *args, **kwargs): # qedge[2] is the edge_index of the queue | ||
| def add_loss( | ||
| self, qedge, *args, **kwargs | ||
| ): # qedge[2] is the edge_index of the queue |
Owner
There was a problem hiding this comment.
Can we move this comment to the next line?
Owner
There was a problem hiding this comment.
Actually, no need to make this change.
| -------- | ||
| Suppose you wanted to model the arrival process as a Poisson | ||
| random measure with rate function :math:`r(t) = 2 + \sin( 2\pi t)`. | ||
| random measure with rate function :math:`r(t) = 2 + \\sin( 2\\pi t)`. |
Owner
There was a problem hiding this comment.
I'm not sure that these latex docstring changes are correct. Things seem to render just fine on readthedocs.io.
djordon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff format .andruff check --fixfrom the root of the project 'after' having added theruff.tomlfile.