Skip to content

fix: use constant-time comparison for auth token (CWE-208) #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spidershield-contrib wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use constant-time comparison for auth token (CWE-208) #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion config.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
import { timingSafeEqual } from 'crypto'
import Providers, { AppProviders } from 'next-auth/providers'
import { prisma, resolvedConfig } from './utils.server'

function safeEqual(a: string, b: string): boolean {
try {
return timingSafeEqual(Buffer.from(a), Buffer.from(b))
} catch {
return false
}
}

/**
* Auth Providers
* https://next-auth.js.org/configuration/providers
Expand All @@ -27,7 +36,8 @@ if (resolvedConfig.useLocalAuth) {
async authorize(credentials: { username: string; password: string }) {
if (
credentials.username === process.env.USERNAME &&
credentials.password === process.env.PASSWORD
process.env.PASSWORD &&
safeEqual(credentials.password, process.env.PASSWORD)
) {
const user = await prisma.user.upsert({
where: {
Expand Down