Restructuring of examples: some \donttest where previously \dontrun#134
Open
mvkorpel wants to merge 13 commits intodkahle:masterfrom
Open
Restructuring of examples: some \donttest where previously \dontrun#134mvkorpel wants to merge 13 commits intodkahle:masterfrom
mvkorpel wants to merge 13 commits intodkahle:masterfrom
Conversation
Fixes cases where there are multiple destinations with the same origin address.
Moved some examples from \dontrun to regular examples which are run with R CMD check and example(<function>). Also added some simple examples if no suitable examples existed. A common feature to these is that they don't require network access. List of functions affected: * LonLat2XY (new example) * XY2LonLat * file_drawer * geocode * get_googlemap * get_stamenmap * mapdist (also fixed the function for urlonly=TRUE) * mutate_geocode (more code moved to \dontrun) * revgeocode (new example) * route (new example) * theme_inset (more code moved to \dontrun) * trek (new example)
\donttest examples are skipped by R CMD check but run by example(<function>) without any extra options. What remains in \dontrun is non-functional code (like register_google() with dummy key) and code using constrained resources (osm tiles) or code otherwise restricted by license agreements.
Commit history is now a bit messy. The intent is to enable applying the changes in this branch on top of previous changes in my other branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now more examples can be run with just
example(funcname)without an extrarun.dontrun=TRUE, which was problematic anyway, as there was (and is) some unrunnable code inside\dontrun. The\donttestexamples are not run byR CMD check, so there's no major increase to check times. My intention also was to keep all possibly problematic (terms of service etc.) examples in\dontrun.Some more examples (some of which are new) are now outside
\dontrunanddonttest. All of these work without network access. This increases the code coverage of the tests run byR CMD check. It is also easy to run thedonttestexamples (no unrunnable code now) withR CMD check --run-donttest.When adding a simple
urlonly=TRUEexample formapdist, I discovered that the option was broken. A fix for that is included. This pull request also includes the changes made in #133.