geocode: add missing parameters to ldply call, closes #207#210
Open
dpprdan wants to merge 2 commits intodkahle:masterfrom
Open
geocode: add missing parameters to ldply call, closes #207#210dpprdan wants to merge 2 commits intodkahle:masterfrom
dpprdan wants to merge 2 commits intodkahle:masterfrom
Conversation
Collaborator
|
@dpprdan thanks for this. Do you want me to add unit tests (since this is drawn towards a bug)? |
Author
|
@scottmmjackson Sorry, I had not thought about this, but yeat, that would be great, because I won't have time for this the next couple of days! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ought to fix #207.
urlonlyfor multiple locationsforcefor multiple locationsfirst call (so that results are cached)
second call
Created on 2018-03-26 by the reprex package (v0.2.0).
Session info
roxygen2::roxygenise(".")?See #206 w.r.t.
roxygenise