Skip to content

Fix transition animations#149

Open
xeophin wants to merge 12 commits intodkaoster:mainfrom
nzzdev:fix-easing
Open

Fix transition animations#149
xeophin wants to merge 12 commits intodkaoster:mainfrom
nzzdev:fix-easing

Conversation

@xeophin
Copy link
Copy Markdown

@xeophin xeophin commented Apr 7, 2025

The code supports now three different animation types:

  • Scroll tracked (scrub video to match the scroll position)
  • Video based, where the video plays at the original speed until it reaches the requested videoPercentage
  • Time based, where the transition takes a fixed amount of time and the video is sped up or slowed down to fit within that time; with the option to modulate the speed using an easing function.

@xeophin
Copy link
Copy Markdown
Author

xeophin commented Apr 7, 2025

Wait, Github tripped me up and made me create a pull request in the wrong repo. Sorry! 🤦🏻‍♂️

Slightly premature PR – you're welcome to ignore it. Or we can discuss whether it needs additional changes, if you're interested in the changes we made.

@dkaoster
Copy link
Copy Markdown
Owner

dkaoster commented Apr 7, 2025

@xeophin no problem, thank you for doing this! I can find some time to look through this and collect some thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants