Multiplayer: Split front_landview.c into two files#4731
Merged
Loobinex merged 3 commits intodkfans:masterfrom May 5, 2026
Merged
Multiplayer: Split front_landview.c into two files#4731Loobinex merged 3 commits intodkfans:masterfrom
Loobinex merged 3 commits intodkfans:masterfrom
Conversation
cerwym
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the reasons landview netcode has been difficult to deal with is because it's been entangled with regular landview, an almost 2000 line file. So to reduce complexity I've extracted out a new file:
front_landview_multiplayer.c.The code already treated
FeSt_NETLAND_VIEWas something distinct fromFeSt_LAND_VIEWand there was already a bunch offrontnetmap_*()andfrontmap_*()alternate versions of functions, so the split seems like a natural fit.I also fixed #4709, #4715, #4665 and added sound effects.