Make set_power_configuration use refactored cfg stuff#4733
Open
PieterVdc wants to merge 4 commits intodkfans:masterfrom
Open
Make set_power_configuration use refactored cfg stuff#4733PieterVdc wants to merge 4 commits intodkfans:masterfrom
PieterVdc wants to merge 4 commits intodkfans:masterfrom
Conversation
25 tasks
There was a problem hiding this comment.
Pull request overview
This PR refactors power configuration updates to use the shared named-field config infrastructure, bringing SET_POWER_CONFIGURATION closer to the existing room/trap/effect-generator config paths and exposing the same capability to Lua.
Changes:
- Replaced the bespoke
SET_POWER_CONFIGURATIONscript parsing/processing code withset_config_check/set_config_processusingmagic_powers_named_fields_set. - Added and registered the Lua
SetPowerConfigurationbinding and updated the Lua binding stub. - Converted power
POWER/COSTparsing inconfig_magic.cto custom named-field handlers and moved spell-tab refresh intoupdate_powers_tab_to_config().
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/lvl_script_commands.c |
Swaps power script handling over to the generic named-field config helpers. |
src/lua_api.c |
Adds the Lua-facing SetPowerConfiguration entry point and registers it globally. |
src/frontmenu_ingame_tabs.c |
Makes power-tab refresh also reopen the active spell menu, matching room/trap refresh behavior. |
src/config_magic.h |
Exports the power named-field set for shared use. |
src/config_magic.c |
Removes the old power command table and adds named-field parsing/assignment for power config values. |
config/fxdata/lua/bindings/config.lua |
Publishes the Lua binding stub for SetPowerConfiguration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.