Draft
Conversation
Owner
|
Wouldn't it be better to directly use numpy within the project instead of generating compatible interfaces? |
Contributor
Author
|
That's ok as well. I was just thinking dcmReader didn't wan't to have numpy as a dependency. Should numpy be a dependency? |
FESTWERTEBLOCK blockParameter2D 4 @ 2 was the last straw. How are you supposed to keep track of dimensions without the st/y and handle if they're split because linelength limits? Going with numpy will deal with all the annoying error handling and once the values are all parsed in a big 1d array then do a simple reshape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example attempt to align return types for values.
The API is inspired by numpy and xarray.
High level ideas:
Only maps works in this form for now. I want some discussion before going all in on this.
References:
https://www.etas.com/download-center-files/products_ASCET_Software_Products/TechNote_DCM_File_Formats.pdf