Skip to content

Fix potential null check error in Socket.select#10939

Merged
thewilsonator merged 1 commit intodlang:stablefrom
rikkimax:nullcheck/socket
Jan 24, 2026
Merged

Fix potential null check error in Socket.select#10939
thewilsonator merged 1 commit intodlang:stablefrom
rikkimax:nullcheck/socket

Conversation

@rikkimax
Copy link
Contributor

Found by @adamdruppe.

It is the classic null + 0 = 0 error. It is fine today, but not forevermore.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 24, 2026

Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#10939"

@rikkimax rikkimax changed the base branch from master to stable January 24, 2026 15:41
@thewilsonator thewilsonator merged commit 440db1e into dlang:stable Jan 24, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants