add Alpine timeout override#10983
Conversation
|
Thanks for your pull request and interest in making D better, @morningstarxcdcode! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10983" |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
120 minutes sounds crazy too me. What is it doing in that time? |
|
Yes, 60 minutes is the current hard max that the CI's are using. If you need more, it's time to investigate why and fix that instead. |
same |
|
anyone please approve this workflow |
|
Hi @0xEAB |
|
@morningstarxcdcode |
|
@0xEAB Sorry for the delay and for marking the conversations resolved without addressing the feedback. You were right on all counts:
I've reverted all of those changes and reduced this PR to the single fix: adding a The net diff is now +1 line. |
d574167 to
59e3cbe
Compare
|
@0xEAB All feedback addressed. The PR now contains a single +1 line change: adding Reverted:
|
08ad29b to
cbb072f
Compare
cbb072f to
21b79e9
Compare






Alpine/musl pushes
test_phobosbeyond the 40-minute default budget.Adds
timeout-minutes: 60to the Alpine matrix entry.