Skip to content

add Alpine timeout override#10983

Open
morningstarxcdcode wants to merge 1 commit into
dlang:masterfrom
morningstarxcdcode:master
Open

add Alpine timeout override#10983
morningstarxcdcode wants to merge 1 commit into
dlang:masterfrom
morningstarxcdcode:master

Conversation

@morningstarxcdcode

@morningstarxcdcode morningstarxcdcode commented Mar 30, 2026

Copy link
Copy Markdown

Alpine/musl pushes test_phobos beyond the 40-minute default budget.
Adds timeout-minutes: 60 to the Alpine matrix entry.

Copilot AI review requested due to automatic review settings March 30, 2026 13:33
@dlang-bot

Copy link
Copy Markdown

Thanks for your pull request and interest in making D better, @morningstarxcdcode! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10983"

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@morningstarxcdcode

Copy link
Copy Markdown
Author

here in this repo it was looking like this

Screenshot 2026-03-30 at 7 05 07 PM

after pr merging it will look like this

Screenshot 2026-03-30 at 7 07 19 PM Screenshot 2026-03-30 at 7 07 37 PM

well i just merge in my main branch for my fock repo so it still neeed time to make all green

Screenshot 2026-03-30 at 7 08 35 PM

see here

@dkorpel

dkorpel commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

120 minutes sounds crazy too me. What is it doing in that time?

@rikkimax

Copy link
Copy Markdown
Contributor

Yes, 60 minutes is the current hard max that the CI's are using.

If you need more, it's time to investigate why and fix that instead.

@morningstarxcdcode

morningstarxcdcode commented Mar 30, 2026

Copy link
Copy Markdown
Author

120 minutes sounds crazy too me. What is it doing in that time?

same
or else it will fail !!

@morningstarxcdcode

Copy link
Copy Markdown
Author

120 minutes sounds crazy too me. What is it doing in that time?

Screenshot 2026-03-30 at 7 38 26 PM

but it actually take some around 39 minutes and 33 seconds to complete.

@morningstarxcdcode

Copy link
Copy Markdown
Author

anyone please approve this workflow

Comment thread .github/workflows/main.yml Outdated
Comment thread .github/workflows/main.yml Outdated
Comment thread .github/workflows/main.yml Outdated
Comment thread .github/workflows/main.yml Outdated
@morningstarxcdcode

Copy link
Copy Markdown
Author

Hi @0xEAB

0xEAB
0xEAB previously requested changes Apr 24, 2026

@0xEAB 0xEAB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite getting repeatedly marked as resolved, the provided feedback has not been addressed yet.

Image

@0xEAB

0xEAB commented Jun 29, 2026

Copy link
Copy Markdown
Member

@morningstarxcdcode
Do you intend to continue your work on this PR?

@morningstarxcdcode

Copy link
Copy Markdown
Author

@0xEAB Sorry for the delay and for marking the conversations resolved without addressing the feedback. You were right on all counts:

  1. The timeout_minutes rename was superfluous — hyphen works fine for custom variables
  2. 120 minutes for macOS was too high — 60 is sufficient, and if it takes longer that signals a real problem
  3. The DMD fallback logic belongs in its own PR

I've reverted all of those changes and reduced this PR to the single fix: adding a timeout-minutes: 60 override for the Alpine job, which was exceeding the 40-minute default.

The net diff is now +1 line.

@morningstarxcdcode morningstarxcdcode force-pushed the master branch 3 times, most recently from d574167 to 59e3cbe Compare June 29, 2026 12:49
@morningstarxcdcode

Copy link
Copy Markdown
Author

@0xEAB All feedback addressed. The PR now contains a single +1 line change: adding timeout-minutes: 60 for the Alpine job, which was exceeding the 40-minute default.

Reverted:

  • macOS timeout stays at 60m (no change from master)
  • Variable rename removed (hyphen is correct)
  • DMD clone fallback removed (belongs in separate PR)
  • set -e restored

@morningstarxcdcode morningstarxcdcode force-pushed the master branch 2 times, most recently from 08ad29b to cbb072f Compare June 29, 2026 13:08
@morningstarxcdcode morningstarxcdcode changed the title Adjust CI timeouts,resilient across branch names and stabilize long-running jobs add Alpine timeout override Jun 29, 2026
@0xEAB 0xEAB dismissed their stale review June 29, 2026 19:17

resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants