feat: SSH key management in KeeAgent entry panel#441
Open
steffen-heil wants to merge 1 commit into
Open
Conversation
5e8ea15 to
78f6c52
Compare
- Generate new Ed25519 SSH keys directly from the key location dialog - Decrypt encrypted key attachments using the entry's password field, resolving placeholders via SprEngine like normal key loading does - Edit the comment of unencrypted attachment keys in-place; the live agent key is swapped atomically on entry-dialog OK (not on Leave), preserving all constraints including DestinationConstraint on reload - Decrypt radio button state updates whenever the attachment selection changes, not only on dialog open Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
78f6c52 to
0ddd95b
Compare
Author
|
Any chance this will be merged? (Already using this in production) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id_ed25519/id_ed25519.pubattachment pair; warns before overwriting an existing keySprEnginefield references, matching normal key-load behaviour); replaces the attachment with an unencrypted copyDetails
SshKeyGenerator.cs— new standalone static class:Generate— Ed25519 key pair via BouncyCastle, OpenSSH wire format, zeroes raw key material infinallyblocksChangeComment— re-serialises an unencrypted private key with a new commentDecrypt— decrypts an encrypted key and re-serialises it without cipher/kdfBuildDecryptedPrivateKey/WriteDecryptedKeyMaterial— shared OpenSSH format builder supporting Ed25519, RSA, ECDSA, DSA, Ed448KeyLocationPanel— fourth radio button "Decrypt existing key (uses entry password)"; enabled only when the current attachment is encrypted and a passphrase is availableManageKeyFileDialog—UpdateDecryptEnabled()called on load and on everyKeyLocationChangedevent so decrypt availability is always currentEntryPanel— comment textbox becomes editable for unencrypted attachment keys; defers live agent reload toFormClosing(DialogResult.OK)to avoid mutating the agent on cancelTest plan
id_ed25519andid_ed25519.pubappear in Attachmentsid_ed25519→ overwrite warning appears🤖 Generated with Claude Code