Open
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
canadaduane
force-pushed
the
create-svg-element2
branch
from
e9b20dd to
7600a0f
Compare
canadaduane
force-pushed
the
create-svg-element2
branch
from
1de5bdf to
1b665eb
Compare
This PR is a sample PR introducing the concept of a call to createElementNS (via createSVGElement). This allows SVG elements to be rendered in DLight. Current limitations: - only works with `svg` and `circle` elements Future questions: - would it be possible to add all SVG element tag names to a defaultSVGTags set? what about tags that exist in both namespaces (e.g. `a`, `title`, `script`, `font` etc.) - perhaps detecting if a tag is a child of an SVG element tag should automatically cause DLight to tag it as belonging to the SVG namespace?
canadaduane
force-pushed
the
create-svg-element2
branch
from
1b665eb to
36b7304
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a sample PR introducing the concept of a call to createElementNS (via createSVGElement). This allows SVG elements to be rendered in DLight.
Context:
svgare created using the defaultcreateElementfunction, which is HTML-only. They are ignored by the browser, and no SVG is rendered.Exploration questions:
a,title,script,fontetc.)