Test Files for color contrast index checking#4
Open
AkimFA wants to merge 50 commits intodlsucomet:updatedfrom
Open
Test Files for color contrast index checking#4AkimFA wants to merge 50 commits intodlsucomet:updatedfrom
AkimFA wants to merge 50 commits intodlsucomet:updatedfrom
Conversation
Added a new function to find indexes of all elements found. Added a new variable to pass in the checkContrast function (index)
Iterates through parent elements to get the background color rather than just using the background by default
made it include to check for the ">" also To pass certain issues such as having the text be element types (i.e. div, p, etc)
Leave in this branch for testing purposes only
Refactored the getIndexes function to make use of regex to read line breaks allowing Added a isThereNoText function to skip checking contrast issues if there is no text
made the callers that call this go straight to getContrastRatio
Made some functions in color-contrast.js async to make use of an api that gets the complement of a color Editted the suggestion to say what color is needed instead of the generic warning
Change how suggestion is passed from color-contrast.js to contrast.js
value being passed to the function was already converted to hex so no need to check other types
Added simple UI to show color scheme suggestion in the side bar Also gets the appropriate text color It might suggest even if there is no issues so will fix
Filtered out duplicates
Added a parseFloat to change the string from the return
Made the color scheme UI wider Added some checks to see if there are any issues and if none, dont do color scheme Removed the name and replaced it with hex value instead
Moved the data formatting to inside the getColorScheme function
Added test files
Change return of alt text for testing purpose added a script to run a node to load images
Currently cannot think of methods to apply background to specific elements that could scale with the html file
express and body parser were added
Force pushed hidden files used in testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files specifically used to test index checking in color contrast for updated branch