🎨 Palette: Fix redundant accessibility announcements on footer icons#130
Conversation
Added `android:importantForAccessibility="no"` to the decorative child `ImageView` elements inside the interactive action buttons (Reply, Boost, Favorite, Bookmark, Share) in `display_item_footer.xml`. Since the content descriptions are managed dynamically on the wrapper layouts (`reply_btn`, `boost_btn`, etc.) by `FooterStatusDisplayItem.java`, marking the inner icons as not important prevents screen readers from redundantly announcing unlabelled images. Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added
android:importantForAccessibility="no"to the innerImageViews of the action buttons (Reply, Boost, Favorite, Bookmark, Share) indisplay_item_footer.xml.🎯 Why: These icons are wrapped in interactive layouts (
reply_btn, etc.) that have dynamic content descriptions managed in Java. Without this change, screen readers could redundantly announce the inner image element without a label. Marking the purely visual icons as not important for accessibility simplifies and cleans up screen reader navigation.♿ Accessibility: Prevents redundant unlabelled image announcements by ensuring screen readers only read the dynamic content description of the parent wrapper layout.
PR created automatically by Jules for task 16546268392058064517 started by @dlukt