-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade eslint from 7.15.0 to 9.26.0 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -1534,7 +1534,7 @@ | |||||
| "@types/vscode": "1.38.0", | ||||||
| "@typescript-eslint/eslint-plugin": "4.10.0", | ||||||
| "@typescript-eslint/parser": "4.10.0", | ||||||
| "eslint": "7.15.0", | ||||||
| "eslint": "9.26.0", | ||||||
|
||||||
| "eslint": "9.26.0", | |
| "eslint": "7.32.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading to eslint@9 will break the current CI/dev runtime setup: this repo’s GitHub Actions pipeline uses Node 12.x (.github/workflows/build-and-test.yml), and ESLint v9 requires a newer Node version, so
npm run compile(which runsnpm run lint) will fail. Either bump the CI Node version (and document the required Node version for contributors) or choose an ESLint major compatible with the project’s Node baseline.