Skip to content

[mt] Add missing CPU tests.#11936

Closed
trivialfis wants to merge 3 commits intodmlc:masterfrom
trivialfis:mt-cpu-tests
Closed

[mt] Add missing CPU tests.#11936
trivialfis wants to merge 3 commits intodmlc:masterfrom
trivialfis:mt-cpu-tests

Conversation

@trivialfis
Copy link
Copy Markdown
Member

ref #9043

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds missing CPU tests for multi-target functionality and includes defensive validation checks in the C++ implementation to prevent unsupported features with multi-target trees.

Changes:

  • Added two new CPU test functions (test_eta and test_column_sampling) to cover learning rate and column sampling functionality for multi-target models
  • Added validation checks in the C++ code to prevent usage of categorical features and distributed training with multi-target trees, which are not yet supported

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/python/test_multi_target.py Adds CPU tests for learning rate (eta) and column sampling to ensure parity with GPU test coverage
src/tree/updater_quantile_hist.cc Adds defensive checks to fail early when unsupported features (categorical features, distributed training) are used with multi-target trees

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@trivialfis trivialfis changed the title [mt] Add missing CPU tests. [wip][mt] Add missing CPU tests. Jan 17, 2026
@trivialfis trivialfis changed the title [wip][mt] Add missing CPU tests. [mt] Add missing CPU tests. Jan 19, 2026
@trivialfis
Copy link
Copy Markdown
Member Author

Merged tests into #11965

@trivialfis trivialfis closed this Jan 29, 2026
@trivialfis trivialfis deleted the mt-cpu-tests branch January 29, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants