Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing CPU tests for multi-target functionality and includes defensive validation checks in the C++ implementation to prevent unsupported features with multi-target trees.
Changes:
- Added two new CPU test functions (
test_etaandtest_column_sampling) to cover learning rate and column sampling functionality for multi-target models - Added validation checks in the C++ code to prevent usage of categorical features and distributed training with multi-target trees, which are not yet supported
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/python/test_multi_target.py | Adds CPU tests for learning rate (eta) and column sampling to ensure parity with GPU test coverage |
| src/tree/updater_quantile_hist.cc | Adds defensive checks to fail early when unsupported features (categorical features, distributed training) are used with multi-target trees |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Merged tests into #11965 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #9043