Add property-based CPU quantile summary tests#12151
Merged
RAMitchell merged 7 commits intodmlc:masterfrom Apr 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restructures CPU quantile summary tests toward property-based invariants by introducing shared deterministic case generation helpers and adding new invariant-focused summary tests.
Changes:
- Added
test_quantile_helpers.hwith deterministic summary case generation and reference/rank-check utilities. - Added new parameterized summary tests validating support monotonicity, exact-retention when representable, and rank-error bounds.
- Removed the legacy
SetPruneInplacesummary-only test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/cpp/common/test_quantile.cc |
Adds new property/invariant-based quantile summary tests and removes the old prune-inplace test. |
tests/cpp/common/test_quantile_helpers.h |
Introduces shared utilities for generating deterministic summary inputs and computing reference/rank-error checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trivialfis
reviewed
Apr 9, 2026
64e7518 to
9e510d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR starts restructuring CPU quantile tests around property-style invariants instead of bespoke one-off cases.
The first step focuses on the summary layer in
tests/cpp/common/test_quantile.cc:SetPruneInplacesummary-only testThis is intended as the first step toward replacing the older ad hoc quantile tests in
test_quantile.ccwith layered property-based tests.Testing
Ran locally:
./build-cpu/testxgboost --gtest_filter='*QuantileSummary*'./build-cpu/testxgboost --gtest_filter='Quantile.*'