Expand CPU quantile property tests and remove redundant cases#12155
Merged
RAMitchell merged 6 commits intodmlc:masterfrom Apr 10, 2026
Merged
Expand CPU quantile property tests and remove redundant cases#12155RAMitchell merged 6 commits intodmlc:masterfrom
RAMitchell merged 6 commits intodmlc:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the CPU quantile test rewrite by adding property-style invariants for summary/container/sketch paths (including distributed row-/col-split) and removing redundant legacy CPU quantile tests.
Changes:
- Refactors summary invariants into a shared helper and adds container-level cut validators (numerical + categorical).
- Adds new CPU property suites covering
HostSketchContainer,SketchOnDMatrix, and distributed row-/column-split behavior. - Removes legacy CPU quantile/hist-util tests that are now covered by the new property checks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/cpp/common/test_quantile.cc |
Adds new property-based test suites for summaries/cuts (local + distributed), and removes redundant legacy tests. |
tests/cpp/common/test_quantile_helpers.h |
Introduces container-case matrix, reference-column tooling, and cut validation helpers used by the new tests. |
tests/cpp/common/test_hist_util.cc |
Removes redundant CPU sketch/cut accuracy tests superseded by the new quantile property coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trivialfis
reviewed
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues the CPU quantile test rewrite by expanding the property-style coverage in
test_quantile.ccand removing redundant legacy CPU quantile tests.The new CPU property suites now cover:
SketchOnDMatrixwrapper invariantsWhat Changed
tests/cpp/common/test_quantile_helpers.htest_quantile.ccandtest_hist_util.ccTesting
cmake --build build-cpu --target testxgboost -j35Result:
140/140passed