fix: use hass setter to guarantee re-render on state changes#19
Merged
Conversation
Replace @Property decorator with explicit getter/setter on hass. Lit's default reference-equality check caused the card to skip re-renders when HA reused the same hass object reference. The setter always calls requestUpdate() ensuring the card updates whenever hass is set. Also add --overwrite to gh release create to handle re-runs for an existing tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The card did not update when GitHub entity data changed in Home Assistant.
Root cause:
@property({ attribute: false })onhassuses Lit's default reference-equality check (oldHass !== newHass). HA sometimes reuses the samehassobject reference when an entity changes, so Lit skips the re-render entirely.Changes
src/github-card.ts@propertydecorator with an explicit getter/setter onhassthis.requestUpdate(), guaranteeing a re-render every time HA pushes new data — regardless of reference equality.github/workflows/release.yml--overwritetogh release createto handle workflow re-runs for an already-published tag