Mingw link issue#3
Open
dmoody256 wants to merge 60 commits into
Open
Conversation
…er, and updated mingw to remove MSVC like nologo flag
Apply the patch (adjusted) from issue SCons#2341: instead of hardcoding the filename extenstion for the tempfile to help with linking on Windows targets, allow some variability. Current marked WIP because there are some other comments in the issue tracker that can maybe be flushed out by submitting this PR, and there are no tests (should presumably go in test/TEMPFILEPREFIX.py, or a new test TEMPFILEEXTENSION.py) Signed-off-by: Mats Wichmann <mats@linux.com>
All the other file extension variables end in SUFFIX, so change this new one to match for consistency. Added doc entry. Signed-off-by: Mats Wichmann <mats@linux.com>
Signed-off-by: Mats Wichmann <mats@linux.com>
Per review comments, subst either return the right thing or None, use this are the way to test for setting default instead of has_key. Signed-off-by: Mats Wichmann <mats@linux.com>
Testing "if not prefix" would return false if an empty string is passed, but that setting should be valid. Signed-off-by: Mats Wichmann <mats@linux.com>
… whitespaces correctly for example "#if(defined FOO)" or "#elif!(BAR)"
customizable tempfile extension (issue SCons#2431)
Enhance cpp scanner regex logic to detect if/elif expressions without whitespaces
dmoody256
force-pushed
the
more_coverage
branch
from
5746afc to
5f22d60
Compare
An earlier change updated some examples, this makes some tweaks to the wording as well for Default, DEFAULT_TARGETS, etc. to clarify. Signed-off-by: Mats Wichmann <mats@linux.com>
…initial support for ARM TARGET_ARCH
Later Pythons (3.6+) enable warnings by default (needed a command line option before then), so some tools give off warnings now. This change quiets the warnings from the gcc, g++ and swig tools. Signed-off-by: Mats Wichmann <mats@linux.com>
Quiet Py3 resource warnings
Codecov Report
@@ Coverage Diff @@
## more_coverage #3 +/- ##
=================================================
+ Coverage 87.77% 87.77% +<.01%
=================================================
Files 187 187
Lines 24279 24283 +4
=================================================
+ Hits 21310 21315 +5
+ Misses 2969 2968 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## more_coverage #3 +/- ##
=================================================
+ Coverage 87.77% 87.77% +<.01%
=================================================
Files 187 187
Lines 24279 24282 +3
=================================================
+ Hits 21310 21313 +3
Misses 2969 2969
Continue to review full report at Codecov.
|
dmoody256
force-pushed
the
more_coverage
branch
from
9b6881a to
9d1a177
Compare
Consolidate Appveyor platforms
…ault Change appendenvpath default
…ng DeciderNeedsNode exception which can be thrown by MD5-Timestamp decider logic
…edsNode exception which can be thrown by MD5-Timestamp decider logic
…s just plain part of a line
…_with_config_force_second_run_exception Issue SCons#3283 fix md5 timestamp with config force second run exception
Improve scons docs regarding Default()
dmoody256
force-pushed
the
mingw_link_issue
branch
from
6d2d97f to
b3f363b
Compare
Doc file had large sections in not very readable format, with lots of tags on single line, etc. Ran through a formatting tool and did some manual fixups. Signed-off-by: Mats Wichmann <mats@linux.com>
…stalled fix for case where nothing is returned from vswhere
The three generated doc files, builders.gen, tools,gen and variables.gen are added to stay in sync with the msvs.xml change. Signed-off-by: Mats Wichmann <mats@linux.com>
Pretty-print msvs.xml
make M4 test cross platform
In doc/SConscript, the function in bootstrap.py to parse a manifest was called with an scons path (#src/engine) but bootstrap does not run in an scons context, it is run via subprocess.Popen. Preprocess the path. Along the way, change the function to open the file itself instead of being passed a list already read from the file, update the comment, and clean some whitespace issues. Signed-off-by: Mats Wichmann <mats@linux.com>
Signed-off-by: Mats Wichmann <mats@linux.com>
Fix problem where API doc gen misses some files
Add arm targets to doc for MSVS_ARCH
dmoody256
force-pushed
the
mingw_link_issue
branch
from
b3f363b to
88621c3
Compare
dmoody256
pushed a commit
that referenced
this pull request
May 1, 2020
Add testcase for GitHub Issue SCons#3540. …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove this paragraph
Please have a look at our developer documentation before submitting your Pull Request.
https://scons.org/guidelines.html
Contributor Checklist:
master/src/CHANGES.txtdirectory (and read theREADME.txtin that directory)