issue #1 initial commit. added clap detection and added tests#2
issue #1 initial commit. added clap detection and added tests#2alex-eli-white wants to merge 1 commit intodmriding:mainfrom
Conversation
|
Happy to rebase with signed commits if needed, lemme know. |
|
@alex-eli-white Blockers: Unused import: use rand_chacha::rand_core::block; in src/passes/rename.rs is unused and will cause a compiler warning. Please remove it. Rebase with signed commits: please rebase onto latest main and sign your commits. I just pushed rust-toolchain.toml and rustfmt.toml which pin the toolchain to 1.91.1 and rustfmt to edition 2024. After rebasing, run cargo fmt, this should eliminate the formatting drift and your diff should only contain your actual feature changes. Suggestions: Minor style: //build list of clap cli crate reserved names is missing a space after //. Test coverage: the clap_preserves_interface test checks that names survive obfuscation, but doesn't verify the roundtrip (decrypt back to original). Consider adding that. Also, the semantic rename path got the clap integration but only the heuristic path is tested. Overall the feature itself is clean and well-scoped, just needs these cleanups. Nice work! |
PR fixes an issue where obfuscation breaks clap-based CLIs by renaming
identifiers that are part of the public interface.
What changes:
Added test coverage using a clap-based fixture to verify: